add cache param to dataApi.findOne (#4653)

superdesk · Oct 4, 2024 · e93bac1 · e93bac1
1 parent ab558e1
commit e93bac1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/scripts/core/helpers/CrudManager.tsx b/scripts/core/helpers/CrudManager.tsx
@@ -121,21 +121,22 @@ export function generatePatchIArticle(a: IArticle, b: IArticle) {
     return patch;
 }
 
-const cache = {};
+const _cache = {};
 
-function findOne<T>(endpoint: string, id: string): Promise<T> {
+function findOne<T>(endpoint: string, id: string, cache: boolean = true): Promise<T> {
     const key = `${endpoint}:${id}`;
 
-    if (cache[key] == null) {
-        cache[key] = httpRequestJsonLocal({
+    if (_cache[key] == null) {
+        _cache[key] = httpRequestJsonLocal({
             method: 'GET',
             path: '/' + endpoint + '/' + id,
+            cache: cache === false ? 'reload' : 'default',
         }).finally(() => {
-            delete cache[key];
+            delete _cache[key];
         });
     }
 
-    return cache[key];
+    return _cache[key];
 }
 
 export function fetchChangedResources<T extends IBaseRestApiResponse>(

diff --git a/scripts/core/helpers/network.tsx b/scripts/core/helpers/network.tsx
@@ -7,6 +7,7 @@ interface IHttpRequestOptions {
     payload?: {};
     headers?: {[key: string]: any};
     urlParams?: {[key: string]: any};
+    cache?: 'default' | 'no-store' | 'reload' | 'no-cache' | 'force-cache' | 'only-if-cached';
 
     abortSignal?: AbortSignal;
 }

diff --git a/scripts/core/superdesk-api.d.ts b/scripts/core/superdesk-api.d.ts
@@ -2553,7 +2553,7 @@ declare module 'superdesk-api' {
     }
 
     export interface IDataApi {
-        findOne<T>(endpoint: string, id: string): Promise<T>;
+        findOne<T>(endpoint: string, id: string, cache?: boolean): Promise<T>;
         create<T>(endpoint: string, item: Partial<T>, urlParams?: Dictionary<string, any>): Promise<T>;
         query<T extends IBaseRestApiResponse>(
             endpoint: string,