-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading configuration from .env
files.
#229
Conversation
c4c0fc2
to
ff73dc5
Compare
@supakeen I see the It's only used in one place, which seems a bit off since Plus, why are you we clearing the tables if the database is destroyed later on along with its tempdirectory ? Is the point of it to ensure that the tables are empty before we start testing ? I was thinking about completely deleting this, but wanted to double check first. EDIT: For the same test instance, the This could be the reason why we have never seen this exception before, I'll have a deeper look later on to see if I can pinpoint why this is happening. Second Edit: |
Let's track these configuration issues in #232 for now. I'll take a look at these issues as well. |
This will do all the heavy lifting of loading config from .env files
This is invoked upon an cli command execution. This also overrides any value in the actual environment with its equivalent in the .env file.
If #239 gets merged, I'll drop this one & make a new PR since the way we handle config will change. |
@supakeen Great! I'll make a new PR to deal with the related issue. |
Closes #227
The changes in this PR will now allow configuring pinnwand through a
.env
file.The configuration in the
.env
file will not take precedence over its equivalent in the system's environment.