Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Containerfile, add docker-compose.yml sample #167

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

CovertDuck
Copy link
Contributor

I renamed Containerfile to Dockerfile as it seems to be the standard for Docker.
I also added a basic build_image.sh script as well as a docker-compose.yml sample to get potential new contributors started a little faster.

@supakeen
Copy link
Owner

supakeen commented Jul 10, 2023

While Dockerfile is the standard for Docker not everyone runs things through Docker. I prefer Containerfile which is understood by more tooling than just Docker. You can pass -f to Docker to build with a custom file.

The docker-compose.yml is supposed to be called compose.yml and with that change I'd like it in here :)

What is the build_image.sh thing?

@CovertDuck
Copy link
Contributor Author

While Dockerfile is the standard for Docker not everyone runs things through Docker. I prefer Containerfile which is understood by more tooling than just Docker. You can pass -f to Docker to build with a custom file.

Oh! I legitimately did not know that about the Containerfiles/Dockerfiles. Thanks :)

The docker-compose.yml is supposed to be called compose.yml and with that change I'd like it in here :)

I can rename the docker-compose.yml.

What is the build_image.sh thing?

As for the build script, I usually create one whenever dealing with a Docker container as to not forget some flags. In this simple build_image.sh I simply make sure that our outgoing image is correctly named and version (tagged). I will often use it to inject (into the Containerfile) versionning that can be seen in-app. A Containerfile cannot do that by itself AFAIK.

But this is my way of things, and not necessarily this team's. I will let you decide between nuking it or keeping it and adding to the script as the project grows. :p

@supakeen
Copy link
Owner

I'm fine with those changes as they are now. Thanks! :)

@supakeen supakeen merged commit 3004116 into supakeen:master Jul 11, 2023
9 checks passed
@sujaldev
Copy link

sujaldev commented Dec 4, 2023

Doesn't the build script require a -f Containerfile flag? It does not work for me without it.

@supakeen
Copy link
Owner

supakeen commented Dec 4, 2023

Doesn't the build script require a -f Containerfile flag? It does not work for me without it.

I am not in a place to test that right now but if it doesn't work please open an issue so I can track it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants