Add Twig CS Fixer for lint and fix tasks #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/twig-cs-fixer
branch
from
26cf88e
to
7703926
Compare
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| $finder = (new PhpCsFixer\Finder()) | |||
| ->in(__DIR__) | |||
| ->ignoreDotFiles(false) | |||
There was a problem hiding this comment.
the .twig-cs-fixer.php and .php-cs-fixer.dist.php where currently ignored but should be included. The VCS files .git is still ignored via ignoreVCS.
Prokyonn
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add Twig CS Fixer.
Why?
After some discussion with @Prokyonn we think it does make sense to add twig cs fixer.
I think the Twig CS Fixer it is a great tool by @VincentLanglet and adding it to our skeleton make other developers aware of that tool. If they don't want to use it they easily can remove it.