Fix use of the correct localizations with multiple portals #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,11 +138,18 @@ public function addUrlsOnPostSerialize(ObjectEvent $event): void | |||
| return; | |||
| } | |||
|
|
|||
| if (null !== ($portal = $attributes->getAttribute('portal'))) { | |||
| $allLocalizations = $portal->getLocalizations(); | |||
There was a problem hiding this comment.
@chirimoya we need to discuss this behaviour.
There was a problem hiding this comment.
To be consistent to the pages and sulu core I'm fine to merge this currently this way.
Still it currently would not be possible to switch to other portals. My personally opinion would output always all localizations and give a hint also in which portals that locales appear.
| @@ -160,6 +167,7 @@ public function addUrlsOnPostSerialize(ObjectEvent $event): void | |||
| $localizations[$locale] = [ | |||
| 'locale' => $locale, | |||
| 'url' => $this->webspaceManager->findUrlByResourceLocator($path, null, $locale), | |||
| 'country' => $localization->getCountry(), | |||
There was a problem hiding this comment.
this case seems to miss here also in sulu core: https://github.com/sulu/sulu/blob/b378ec72f296afedbf913967e5e66604737f4b48/src/Sulu/Bundle/WebsiteBundle/Resolver/TemplateAttributeResolver.php#L100
Use the correct localizations of the portal if multiple portals are configured and ´country´ key to the localizations array to match it with the other implementations in sulu.
alexander-schranz
added
the
bug
alexander-schranz
force-pushed
the
bugfix/fix-portal-localizations-reslove
branch
from
9201576
to
6676e17
Compare
wachterjohannes
pushed a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct localizations of the portal if multiple portals are configured and ´country´ key to the localizations array to match it with the other implementations in sulu.
What's in this PR?
This fixes an issue with localizations when you split them in multiple portals.
Why?
Before this change all localizations of a webspace were returned even if you had separated them in multiple portals.
After this change, only localizations of the active portal are returned if you have multiple portals.
Also, the
countrykey was added to match the output of pages.