Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/coor tooltip #158

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/coor tooltip #158

wants to merge 2 commits into from

Conversation

GZwong
Copy link

@GZwong GZwong commented Feb 6, 2024

Description

  • Implemented a tooltip window when hovering/moving points on the Torque Map
  • The point tooltip window shares the underlying object as the deadzone tooltip window via shared pointers

Closes #53

Checklist

  • Code linted with trunk check
  • Code formatted with trunk fmt
  • Changes do not generate any new compiler warnings
  • Commit messages follow the Conventional Commits Specification

Addresses #53

Use a shared pointer instead of a unique pointer to control the tooltip. Interacting with the deadzone or points uses the same underlying tooltip object.
@tgodfrey0
Copy link
Member

Looks good, the only thing is that it makes the line move in discrete jumps instead of continuously. If you could just increase the number of points in the space we should get smother motion then it can be merged.

@GZwong
Copy link
Author

GZwong commented Mar 12, 2024

Looks good, the only thing is that it makes the line move in discrete jumps instead of continuously. If you could just increase the number of points in the space we should get smoother motion then it can be merged.

Currently, points are added by:

  1. Finding which pixel on the GUI is clicked on - this is handled by JUCE
  2. Transforming the pixel location from the GUI reference frame to actual X and Y data of the graph
  3. Paint the points in the GUI reference frame

Unfortunately, to increase the number of points in the space, we would need JUCE to register finer changes in pixel that is clicked upon, which I do not think is possible with current function that is used. I am looking at alternative, lower-level methods to interact with the pixels of the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(gui): add tooltip to show point coordinates
2 participants