Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed qs #2116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed qs #2116

wants to merge 3 commits into from

Conversation

gkiely
Copy link

@gkiely gkiely commented Jun 23, 2024

Based off this comment
#2038 (comment)

Includes a lightweight alternative to qs.stringify that can run in worker environments.
I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@helenye-stripe
Copy link
Contributor

Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯

@chenglou
Copy link

Seems like the only failures are prettier-related?

@prathmesh-stripe
Copy link
Contributor

@chenglou Our CI pipeline does not run the test suite until build failures are resolved first. We are waiting for @gkiely to make progress on this and add rest of the tests that they intend to add in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants