-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Card brand filtering for PAN and saved payment methods #4056
Conversation
🚨 New dead code detected in this PR: CardSectionElement.swift:63 warning: Property 'cardBrandFilter' is assigned, but never used Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
6 builds increased size
StripeSize 1.0 (1)
|
Item | Install Size Change |
---|---|
Other | ⬆️ 172 B |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 112 B
Total download size change: ⬆️ 93 B (0.02%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 112 B |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 112 B
Total download size change: ⬆️ 305 B (0.02%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 112 B |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 112 B
Total download size change: ⬇️ 88 B
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 112 B |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 172 B
Total download size change: ⬇️ 2.1 kB (-0.11%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 172 B |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 11.9 kB (0.12%)
Total download size change: ⬆️ 7.6 kB (0.22%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬆️ 8.0 kB |
🗑 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬇️ -8.0 kB |
📝 StripePaymentSheet.CardBrandFilter.isAccepted(cardBrand) | ⬆️ 916 B |
DYLD.Exports | ⬆️ 720 B |
Other | ⬆️ 10.3 kB |
🛸 Powered by Emerge Tools
%1$@ is not accepted If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link. |
Summary
In a future PR:
Motivation
https://docs.google.com/document/d/1DD7mncHsHbMtU_jqr_TnaLL8ltjO61pPmdOAlJXxYHY/edit
Testing
Changelog
N/A for now