Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose 1.6.8. #9317

Closed
wants to merge 10 commits into from
Closed

Compose 1.6.8. #9317

wants to merge 10 commits into from

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Sep 24, 2024

Summary

This updates compose to 1.6.8.

Motivation

We've seen reported issues with updating lifecycle, and to prevent that, I'm updating compose.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │            uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff       
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
      dex │   3.9 MiB │     4 MiB │   +44 KiB │   8.6 MiB │   8.7 MiB │    +73 KiB 
     arsc │   2.3 MiB │   2.3 MiB │ +28.8 KiB │   2.3 MiB │   2.3 MiB │  +28.8 KiB 
 manifest │   5.1 KiB │   5.1 KiB │       0 B │  25.6 KiB │  25.6 KiB │        0 B 
      res │ 932.5 KiB │ 932.7 KiB │    +185 B │   1.5 MiB │   1.5 MiB │     +328 B 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │     6 MiB │        0 B 
    asset │   2.9 MiB │   2.9 MiB │  -1.3 KiB │   2.9 MiB │   2.9 MiB │   -1.3 KiB 
    other │ 195.8 KiB │ 196.1 KiB │    +262 B │ 430.3 KiB │ 430.5 KiB │     +226 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
    total │  12.8 MiB │  12.9 MiB │ +71.9 KiB │  21.7 MiB │  21.8 MiB │ +100.9 KiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 42625 │ 42475 │ -150 (+6564 -6714)   
   types │ 14127 │ 14250 │ +123 (+6088 -5965)   
 classes │ 11765 │ 11873 │ +108 (+5184 -5076)   
 methods │ 60355 │ 61032 │ +677 (+39023 -38346) 
  fields │ 40022 │ 40235 │ +213 (+31081 -30868) 

 ARSC    │ old  │ new  │ diff         
─────────┼──────┼──────┼──────────────
 configs │  242 │  242 │   0          
 entries │ 6245 │ 6264 │ +19 (+24 -5)
APK
      compressed      │      uncompressed      │                                                                         
──────────┬───────────┼───────────┬────────────┤                                                                         
 size     │ diff      │ size      │ diff       │ path                                                                    
──────────┼───────────┼───────────┼────────────┼─────────────────────────────────────────────────────────────────────────
    4 MiB │   +44 KiB │   8.7 MiB │    +73 KiB │ ∆ classes.dex                                                           
  2.3 MiB │ +28.8 KiB │   2.3 MiB │  +28.8 KiB │ ∆ resources.arsc                                                        
  6.5 KiB │  -1.4 KiB │   6.3 KiB │   -1.4 KiB │ ∆ assets/dexopt/baseline.prof                                           
    546 B │    +546 B │   1.1 KiB │   +1.1 KiB │ + res/-81.xml                                                           
          │    -396 B │           │     -500 B │ - res/color/m3_slider_halo_color.xml                                    
    206 B │    +206 B │       6 B │       +6 B │ + META-INF/androidx.lifecycle_lifecycle-runtime-compose.version         
    127 B │    +127 B │       5 B │       +5 B │ + META-INF/services/I9.A                                                
    127 B │    +127 B │       5 B │       +5 B │ + META-INF/services/J9.a                                                
          │    -127 B │           │       -5 B │ - META-INF/services/A9.A                                                
          │    -127 B │           │       -5 B │ - META-INF/services/B9.a                                                
    1 KiB │     +78 B │     913 B │      +78 B │ ∆ assets/dexopt/baseline.profm                                          
 50.1 KiB │     +41 B │ 118.2 KiB │     +110 B │ ∆ META-INF/MANIFEST.MF                                                  
 53.3 KiB │     +14 B │ 118.3 KiB │     +110 B │ ∆ META-INF/CERT.SF                                                      
    526 B │      +8 B │     840 B │        0 B │ ∆ res/bt.xml                                                            
    551 B │      +7 B │     828 B │     -324 B │ ∆ res/-8.xml                                                            
    541 B │      +4 B │     984 B │        0 B │ ∆ res/J7.xml                                                            
    303 B │      -3 B │     400 B │        0 B │ ∆ res/OH.xml                                                            
    960 B │      -3 B │   2.7 KiB │        0 B │ ∆ res/ZW.xml                                                            
    450 B │      +3 B │     500 B │        0 B │ ∆ res/color/material_personalized_color_secondary_text_inverse.xml      
    467 B │      -3 B │     844 B │        0 B │ ∆ res/color/wallet_primary_text_holo_light.xml                          
    303 B │      +2 B │     352 B │        0 B │ ∆ res/-5.xml                                                            
    908 B │      +2 B │     2 KiB │        0 B │ ∆ res/2j.xml                                                            
    460 B │      +2 B │     652 B │        0 B │ ∆ res/4I.xml                                                            
    630 B │      +2 B │     1 KiB │        0 B │ ∆ res/Hc.xml                                                            
    596 B │      -2 B │   1.1 KiB │        0 B │ ∆ res/JB.xml                                                            
    324 B │      -2 B │     388 B │        0 B │ ∆ res/Kt.xml                                                            
  1.1 KiB │      +2 B │   2.7 KiB │        0 B │ ∆ res/L-.xml                                                            
    279 B │      -2 B │     372 B │        0 B │ ∆ res/c6.xml                                                            
    434 B │      -2 B │     500 B │        0 B │ ∆ res/color-v31/m3_dynamic_dark_primary_text_disable_only.xml           
    395 B │      +2 B │     500 B │        0 B │ ∆ res/color/m3_chip_assist_text_color.xml                               
    413 B │      +2 B │     500 B │        0 B │ ∆ res/color/m3_dark_default_color_primary_text.xml                      
    420 B │      +2 B │     500 B │        0 B │ ∆ res/color/m3_dark_default_color_secondary_text.xml                    
    463 B │      +2 B │     668 B │        0 B │ ∆ res/color/m3_icon_button_icon_color_selector.xml         
...✂
DEX
STRINGS:

   old   │ new   │ diff               
  ───────┼───────┼────────────────────
   42625 │ 42475 │ -150 (+6564 -6714) 
  
  + 
              |
  +  (reason=
  +  in the map
  +  int arguments (
  +  ints and 
  +  must be between 0 .. 
  +  must be in 0..
  +  object arguments (
  +  objects.
  +  without arguments because it expects 
  + (this)
  + ) and 
  + ) is not null
  + ) is out of bounds [0,
  + ) is out of range. Each dimension must be between 0 and 16777215.
  + ) or end(
  + ), currentThread={id=
  + ), prevOffset=
  + ,
  KeepUntilTransitionsFinished - 
  + , anchor=
  + , applied=
  + , arrangementSpacing=
  + , blendMode=
  + , but was 
  + , converter=
  + , crossAxisSize=
  + , crossed=
  + , disposed=
  + , effectsMap=
  + , enter=
  + , exit=
  + , finishedListener=
  + , graphicsLayerBlock=
  + , handlesCrossed=
  + , hold=
  + , horizontalArrangement=
  + , info=
  
  + , isShowingSubstitution=
  + , layoutCache=
  + , lowestPin=
  + , offsetAnimation=
  + , originalEventPosition=
  + , overrideDescendants=
  + , placementSpec=
  + , platformImeOptions=null)
  + , propagateMinConstraints=
  + , selectableId=
  + , sizeAnimation=
  + , slideAnimation=
  + , spec: 
  + , substitution=
  + , target: 
  + , toDpValues=
  + , verticalArrangement=
  + , visible=
  + ,deviceId=
  + . Not all arguments were provided. Missing 
  + A initializer with the same clazz has already been added: 
  + ARGB_4444
  + AccessibilityKey: 
  + ActiveParent with no focused child
  + Already pushed argument 
  + AnchorInfo(direction=
  + AnimateItemElement(appearanceSpec=
  + AnimationVector3D: v1 = 
  + Array lengths must match and be nonzero
  + Array size not a multiple of 3
  + Asking for intrinsic measurements of SubcomposeLayout layouts is not supported. This includes components that are built on top of SubcomposeLayout, such as lazy lists, BoxWithConstraints, TabRow, etc. To mitigate this:
  - if intrinsic measurements are used to achieve 'match parent' sizing, consider replacing the parent of the component with a custom layout which controls the order in which children are measured, making intrinsic measurement not needed
  - adding a size modifier to the component, in order to fast return the queried intrinsic measurement.
  + AutoMirrored.Filled.KeyboardArrowRight
  + BlendModeColorFilter(color=
  + BoxMeasurePolicy(alignment=
  + Built-in InterruptionHandlingOffset
  + Built-in alpha
  + Built-in scale
  + Built-in shrink/expand
  + Built-in slide
  + COLLAPSED
  + CROSSED
  + Call next() before removing an element.
  + Can only append a slot if not current inserting
  + Can only update the current state with MutableTransitionState
  + CancelTraversal
  + Cannot call set before the first call to next() or previous() or immediately after a call to add() or remove()
  + Cannot disable reuse from root if it was caused by other groups
  + Cannot end node insertion, there are no pending operations that can be realized.
  + Cannot find value for key 
  + Cannot pop(), because the stack is empty.
  + Cannot push 
  + Capacity must be a positive value.
  + Clear is not valid on OffsetApplier
  + ClearTextSubstitution
  + Composable 
  + Compose:deactivate
  + Composition is disposed while composing. If dispose is triggered by a call in @Composable function, consider wrapping it with SideEffect block.
  + CompositionLocal LocalLifecycleOwner not present
  + ContinueTraversal
  + Could not resolve state for movable content
  + D1
  + Deactivated node is focused
  + DensityWithConverter(density=
  + DepthSortedSet.add called on an unattached node
  + DepthSortedSet.remove called on an unattached node
  + Detected multithreaded access to SnapshotStateObserver: previousThreadId=
  + DynamicValueHolder(state=
  + EnterExitTransitionElement(transition=
  + Error attempting to load resource: 
  + Error while pushing 
  + Error: Placement happened before lookahead.
  + Error: currentPostLookaheadIndex cannot be greater than the size of thepostLookaheadComposedSlotIds list.
  + Error: requestLookaheadRemeasure cannot be called on a node outside LookaheadScope
  + ExitTransition.KeepUntilTransitionsFinished
  + Expected AndroidViewHolder to be attached when observing reads.
  + Expected index to be within 0..size()-1, but was 
  + FFFFI
  + FFLL
  + FIII
  + FIZZZ
  + FZLI
  + FixupList has pending fixup operations that were not realized. Were there mismatched insertNode() and endNodeInsert() calls?
  + FontScaleConverter
...✂
ARSC
ENTRIES:

   old  │ new  │ diff         
  ──────┼──────┼──────────────
   6245 │ 6264 │ +19 (+24 -5) 
  + attr/indicatorTrackGapSize
  + attr/showMarker
  + attr/thumbHeight
  + attr/thumbTrackGapSize
  + attr/thumbWidth
  + attr/trackInsideCornerSize
  + attr/trackStopIndicatorSize
  + dimen/m3_carousel_small_item_size_min
  + dimen/m3_comp_progress_indicator_active_indicator_track_space
  + dimen/m3_comp_progress_indicator_stop_indicator_size
  + dimen/m3_comp_progress_indicator_track_thickness
  + dimen/m3_comp_scrim_container_opacity
  + dimen/m3_comp_slider_active_handle_height
  + dimen/m3_comp_slider_active_handle_leading_space
  + dimen/m3_comp_slider_active_handle_width
  + dimen/m3_comp_slider_stop_indicator_size
  + drawable/indeterminate_static
  + id/escape
  + id/transition_clip
  + id/transition_image_transform
  + id/transition_pause_alpha
  + string/tooltip_description
  + string/tooltip_label
  + style/Widget.Material3.CircularProgressIndicator.Legacy.ExtraSmall
  
  - color/m3_slider_halo_color
  - dimen/m3_comp_circular_progress_indicator_active_indicator_width
  - dimen/m3_comp_linear_progress_indicator_active_indicator_height
  - dimen/m3_slider_inactive_track_height
  - dimen/m3_slider_thumb_elevation

@@ -33,6 +33,7 @@ dependencies {
implementation libs.compose.activity
implementation libs.compose.foundation
implementation libs.compose.material
implementation libs.compose.materialIcons
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why this started not compiling, but we didn't have this dependency in these modules, but we were using the dependencies.

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.6.8 branch 3 times, most recently from db17677 to b6c4201 Compare September 25, 2024 14:18
Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@jaynewstrom-stripe
Copy link
Collaborator Author

Separated into smaller PRs, and will ultimately land as #9345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant