-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more event support #231
Conversation
@rvilarl let's continue the conversation from #230 (comment) here. I'm not getting the same result as the test. I'm using In the tests, I saw something dealing with I suspect that this |
…turned duplicate data
To me the ModifierContext looks good: there is one Accidental and one StaveNote as expected. |
I'm using |
@jaredjj3 this is why I said that I had been working in BoundigBox. I resolved some problems but I expect more bugs. Let me know if you come across them. |
@rvilarl will do, thanks for improving it! |
This PR fixes #227 by adding a basic event system. It adds an overlay element, which makes the event behavior consistent between SVG and canvas. Without this, SVG elements would "steal" touchend and touchcancel. I decided to leave the event system very bare and simple for now. I'll try to revisit before 1.0.0.