This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
108 oauth #156
Draft
108 oauth #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always return index if a path cannot be met - security tests to ensure index is protected Contributes to: strimzi#154 Signed-off-by: Nic Townsend <[email protected]>
- restructure ConfigFeatureFlag assets so they are no longer exporting test code as runtime dependencies Contributes to: strimzi#152 Signed-off-by: Nic Townsend <[email protected]>
- introduce passport - add a passport local strategy for authentication - introduce Authentication interface to contain the multiple auth checks (authenticate, checkAuth, logout) - scram router module for authentication, logout, and auth check - no op for no auth - extend auth support to provide additional functions to all modules for checking auth, logging out - remove empty placeholder file Contributes to: strimzi#106 Signed-off-by: Nic Townsend <[email protected]>
nictownsend
force-pushed
the
108-oauth
branch
from
3385035
to
00a60a8
Compare
PR ReportBundle SizesTest CoverageView test coverage
Triggered by commit: 2ee0ba3 |
nictownsend
force-pushed
the
108-oauth
branch
2 times, most recently
from
3f48b63
to
de5bdde
Compare
|
Finishing off the test coverage, but PR is here for review. For compile purposes it's based off other PRs. Please only review the final commit (rest will be removed once in main branch). |
- passport strategy - new config for oidc routes Contributes to: strimzi#106 Signed-off-by: Nic Townsend <[email protected]>
nictownsend
force-pushed
the
108-oauth
branch
from
de5bdde
to
1a51212
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108