Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

fixed image locations in summit labs #24

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hodrigohamalho
Copy link

No description provided.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this attribute in the root doc file:
:imagesdir: ./images
Did you have any problems with that?

@hodrigohamalho
Copy link
Author

hodrigohamalho commented Jul 29, 2018

Yes, I did. The images doesn't load.

Check it at: https://github.com/strimzi/strimzi-lab/blob/master/rh-summit-2018/module-01.adoc

And the other modules...

@ppatierno
Copy link
Member

I know that images aren't showed in the GitHub repo but the documentation is made with the objective to be made using asciidoctor in order to build the final HTML file and not having them available directly in the repo.

@ppatierno
Copy link
Member

Another thing, I don't think that we have to adapt the documentation to the new Strimzi version. This is the demo of the RH Summit 2018 where we used Strimzi 0.3.0 during the lab. We don't want to update this demo every time a new Strimzi version will come.

@hodrigohamalho
Copy link
Author

I agree with you with the demo update strategy, but the documentation (broken images, etc) I think it should be always working independent of the version.

Just my 2cents.

@ppatierno
Copy link
Member

I see your point but Strimzi is a fast evolving project and breaking changes happen quite easily. For this reason the summit 2018 demo should work out of box without changes. We'll hve something different in the future as you suggest with doc not related to release.

Base automatically changed from master to main March 25, 2021 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants