feat: bun support with npm fallback #29267
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings
| EUNKNOWNTYPE: 'Unknown type encountered.', | ||
| }; | ||
|
|
||
| export class BUNProxy extends JsPackageManager { |
There was a problem hiding this comment.
style: Consider renaming to BunProxy for consistency with other package manager proxies
| async getNpmVersion(): Promise<string> { | ||
| return this.executeCommand({ command: 'npm', args: ['--version'] }); | ||
| } |
There was a problem hiding this comment.
logic: getNpmVersion uses npm instead of bun. Consider implementing a getBunVersion method
| }); | ||
| } | ||
|
|
||
| public async findInstallations(pattern: string[], { depth = 99 }: { depth?: number } = {}) { |
There was a problem hiding this comment.
logic: findInstallations method uses npm instead of bun. Implement a bun-specific version or handle potential differences
| public async getRegistryURL() { | ||
| const res = await this.executeCommand({ | ||
| command: 'npm', | ||
| // "npm config" commands are not allowed in workspaces per default | ||
| // https://github.com/npm/cli/issues/6099#issuecomment-1847584792 | ||
| args: ['config', 'get', 'registry', '-ws=false', '-iwr'], | ||
| }); | ||
| const url = res.trim(); | ||
| return url === 'undefined' ? undefined : url; | ||
| } |
There was a problem hiding this comment.
logic: getRegistryURL uses npm. Implement a bun-specific method or handle potential differences
| }); | ||
| } | ||
|
|
||
| protected async runGetVersions<T extends boolean>( |
There was a problem hiding this comment.
logic: runGetVersions uses npm. Implement a bun-specific method or handle potential differences
| infoCommand: 'npm ls --depth=1', | ||
| dedupeCommand: 'npm dedupe', |
There was a problem hiding this comment.
logic: infoCommand and dedupeCommand use npm. Update to use bun equivalents if available
Closes #28164
What I did
Added bun support and npm fallback to those where bun lacks
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR introduces support for the Bun package manager in Storybook, addressing issue #28164.
BUNProxyclass incode/core/src/common/js-package-manager/BUNProxy.tsfor Bun-specific operationsPackageManagerNametype inJsPackageManagerto include 'bun'