Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API docs for new withStorybook wrapper #610

Merged
merged 12 commits into from
Oct 3, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 30, 2024

N/A

What I did

Simple API docs update

The rest of the README needs to be cleaned up and updated to 8 before we release

@shilman shilman added the documentation Improvements or additions to documentation label Sep 30, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dannyhw
Copy link
Member

dannyhw commented Sep 30, 2024

❤️ awesome

@shilman shilman force-pushed the shilman/withstorybook-wrapper branch from 18838aa to 7736e64 Compare September 30, 2024 16:10
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman, thanks for taking the time to make the changes and help out with the documentation. Appreciate it 🙏 ! I left a couple of items for you to look into when you can.

@dannyhw Also, while we're at it, I left one item for consideration. Let me know, and we'll take it from there.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: jonniebigodes <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
shilman and others added 10 commits October 2, 2024 07:31
Co-authored-by: jonniebigodes <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: Kyle Gach <[email protected]>
Co-authored-by: jonniebigodes <[email protected]>
Co-authored-by: jonniebigodes <[email protected]>
@dannyhw
Copy link
Member

dannyhw commented Oct 3, 2024

Seems like everything has been resolved, thanks everyone for your help 🙏

@dannyhw dannyhw merged commit 9c52954 into next Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants