Add support for resolving devices by partlabel and partuuid #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbzatek thanks for picking this up 👍 LGTM. |
|
Jenkins, test this please. |
1 similar comment
|
Jenkins, test this please. |
tbzatek
force-pushed
the
resolve_device
branch
from
7017a5f
to
5b158db
Compare
|
Needs a fix in #955 to solve the failing new tests. |
Also fixes the wrong logic about "matching all values". Note that unmangled/unescaped strings should be provided as appearing on the org.freedesktop.UDisks2.Block and org.freedesktop.UDisks2.Partition interfaces.
tbzatek
force-pushed
the
resolve_device
branch
from
5b158db
to
cf47eee
Compare
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @agners PR #861