Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Upgrade the sdk-go to use ce_ prefix #936

Merged
merged 2 commits into from
Aug 29, 2024
Merged

🌱 Upgrade the sdk-go to use ce_ prefix #936

merged 2 commits into from
Aug 29, 2024

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented May 22, 2024

Summary

Related issue(s)

Fixes # cloudevents/sdk-go#1059

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yanmxa
Copy link
Member Author

yanmxa commented May 22, 2024

/retest

@yanmxa yanmxa mentioned this pull request May 22, 2024
Merged
@yanmxa
Copy link
Member Author

yanmxa commented Jun 20, 2024

/override ci/prow/test-integration

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 20, 2024

@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/test-integration

In response to this:

/override ci/prow/test-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanmxa yanmxa closed this Jul 2, 2024
@clyang82 clyang82 reopened this Aug 28, 2024
@yanmxa
Copy link
Member Author

yanmxa commented Aug 28, 2024

/cc @clyang82

@openshift-ci openshift-ci bot requested a review from clyang82 August 28, 2024 13:52
clyang82
clyang82 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-merge-bot openshift-merge-bot bot merged commit 1e1543e into stolostron:main Aug 29, 2024
14 checks passed
@yanmxa yanmxa deleted the br_upgrade_cd_prefix branch September 20, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyang82 clyang82 clyang82 approved these changes

Assignees

@clyang82 clyang82

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanmxa @clyang82 @openshift-merge-robot