Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #2716) Add support for module-inlining calls to polymorphic kernels/routines #2732

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

arporter
Copy link
Member

@arporter arporter commented Oct 3, 2024

No description provided.

@arporter arporter self-assigned this Oct 3, 2024
@arporter arporter marked this pull request as draft October 3, 2024 09:12
@arporter arporter added in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH labels Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 97.26027% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.85%. Comparing base (dd35000) to head (ba58c82).

Files with missing lines Patch % Lines
src/psyclone/psyGen.py 88.88% 2 Missing ⚠️
...mmon/transformations/kernel_module_inline_trans.py 98.98% 1 Missing ⚠️
...n_move_iteration_boundaries_inside_kernel_trans.py 80.00% 1 Missing ⚠️
...main/gocean/transformations/gocean_opencl_trans.py 83.33% 1 Missing ⚠️
src/psyclone/transformations.py 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
- Coverage   99.86%   99.85%   -0.02%     
==========================================
  Files         354      354              
  Lines       48893    48930      +37     
==========================================
+ Hits        48829    48857      +28     
- Misses         64       73       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter
Copy link
Member Author

arporter commented Oct 3, 2024

As well as addressing the coverage, I need to extend the LFRic integration tests to use this new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant