Cell Width, Text Wrap, Font/Background Color, Table Options #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs column width patch to make sense
a value consisting of only spaces should be processed as a string, not a number
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the library only outputs column widths if autowidth is set for the column, and ignores any auto calculated widths. This fixes that issue by always writing the column, and also gives the user greater control by allowing an optional cell width property. Also added a wrapText (boolean) cell property to support cell text wrapping.
Added table options, worksheet.table can still be specified as boolean, or object with optionional topLeftRow, topLeftColumn, style, stripeColumns and stripRows properties (for example for a table starting at A3 rather than A1, {topLeftRow: 3, topLeftColumn:0, style:'tableStyleNone'}
Added support for background fill via backgroundColor property
Added support for font color via the fontColor property
Fixed bug with string detection, " " was not detected as a string (isFinite returned true)