Refactor/revise graphviz use native dot quarto #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwjohnst86
commented
May 27, 2024
Comment on lines
+460
to
+462
| ```{dot} | ||
| //| label: fig-intermediate-confounding | ||
| //| fig-cap: "Confounding by an intermediate pathway." |
There was a problem hiding this comment.
This is a way to label and include a caption for this figures!
| confounder of M and Y. When considering the effect on Y of changes to X | ||
| via a specific mediator M, the presence of L is challenging and | ||
| regression-based methods could no longer handle this situation. | ||
| Like @fig-intermediate-confounding below, L is influenced by the |
There was a problem hiding this comment.
You can reference the image anywhere in the website with this tag
lwjohnst86
requested review from
omarsilverman,
arborzhang and
danielibsen
and removed request for
omarsilverman and
arborzhang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can directly insert GraphViz images and syntax into Quarto Documents: https://quarto.org/docs/authoring/diagrams.html#graphviz so this PR (which stacks on the others) refactors all the DiagrammeR code into the native Quarto dot syntax. I also removed DiagrammeR as a package dependency.
The bonus of using this approach is that the images look much better on the website, compared to DiagrammeR. The problem with DiagrammeR is that it hasn't been updated in a while, so the graphviz version used is old.