Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community)_: fix missing mediaserver when cloning a community #6026

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jrainville
Copy link
Member

@jrainville jrainville commented Nov 1, 2024

Found while fixing status-im/status-desktop#16688

This caused communities being passed to the client via handleCommunitiesSubscription to not have images and they would "flash" in the client because it would disappear for a second then come back when another signal updated it back.

This caused communities being passed to the client via `handleCommunitiesSubscription` to not have images and they would "flash" in the client because it would disappear for a second then come back when another signal updated it back.
@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d6a8ef4 #1 2024-11-01 19:26:23 ~4 min macos 📦zip
✔️ d6a8ef4 #1 2024-11-01 19:26:38 ~4 min linux 📦zip
✔️ d6a8ef4 #1 2024-11-01 19:26:42 ~4 min tests-rpc 📄log
✔️ d6a8ef4 #1 2024-11-01 19:27:30 ~5 min ios 📦zip
✔️ d6a8ef4 #1 2024-11-01 19:27:52 ~5 min windows 📦zip
✔️ d6a8ef4 #1 2024-11-01 19:27:58 ~6 min android 📦aar
✔️ d6a8ef4 #1 2024-11-01 19:29:45 ~7 min macos 📦zip
✔️ d6a8ef4 #1 2024-11-01 19:57:09 ~35 min tests 📄log

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants