perf(admin): unload admin panel when leaving it to preserve performance #16425
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterates #16043 By unloading the admin panel when leaving it, we can free the memory and also make sure that further updates to the community don't try to update the invisible models from the admins panels, some of which are very heavy.
jrainville
requested review from
a team,
iurimatias,
osmaczko and
micieslak
and removed request for
a team
Jenkins Builds
|
micieslak
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterates #16043
By unloading the admin panel when leaving it, we can free the memory and also make sure that further updates to the community don't try to update the invisible models from the admins panels, some of which are very heavy.
The downside is that if you were in a particular screen in the admin panel, go back to the community to answer a message or retrieve an address, you will have lost your state.
However, I got Jen's blessing to do this change, as she is having a lot of issues with memory and performance currently.
Later, when we have upgraded all models and proxies, we might want to revert this change.
Affected areas
Admin Panel (especially when leaving and going back)
Architecture compliance
My PR is consistent with this document: Architecture guidelines
Impact on end user
better performance when the admin tab is closed with the tradeoff of losing the last state.
How to test
See that we are back at the Overview
Risk
Tick one:
No risk