test: retry dns discovery #16411
Closed
test: retry dns discovery #16411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
richard-ramos
force-pushed
the
retry-dns-disc
branch
from
5d6df4e
to
3feeb99
Compare
|
Closing PR as this has been already merged in status-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
This PR adds a retry mechanism for dns discovery URLs that fail to be retrieved by periodically attempting to resolve the URL with a backoff period that will increase up to 1m.
This PR is very simple to test: we should disconnect the internet and login. Once logged in, reconnect to the internet. The retry mechanism will attempt to retrieve the values from the DNS Discovery URL, and peer discovery should happen again.