storybook: test_mintTokensIntroPages added #16362
Open
+138
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiyaig
force-pushed
the
storybook-test-for-tokens-page
branch
from
b3be00c
to
f27e910
Compare
Jenkins BuildsClick to see older builds (43)
|
anastasiyaig
requested review from
alexjba,
Khushboo-dev-cpp,
caybro and
micieslak
caybro
reviewed
Sep 19, 2024
caybro
reviewed
Sep 19, 2024
alexjba
approved these changes
Sep 19, 2024
anastasiyaig
force-pushed
the
storybook-test-for-tokens-page
branch
from
89d81e8
to
548c707
Compare
anastasiyaig
force-pushed
the
storybook-test-for-tokens-page
branch
from
548c707
to
1e527b9
Compare
caybro
approved these changes
Sep 20, 2024
fails with segfault, but it was even before my changes :/ |
I'll check it out locally EDIT: and it works just fine on my machine... |
it works to me perfectly as well |
I'll have a look :) |
|
Did a full run locally: |
caybro
force-pushed
the
storybook-test-for-tokens-page
branch
2 times, most recently
from
21bb379
to
9990c84
Compare
caybro
force-pushed
the
storybook-test-for-tokens-page
branch
2 times, most recently
from
aaf8eec
to
5630652
Compare
micieslak
reviewed
Sep 20, 2024
Comment on lines
+79
to
+103
| compare(htmlToPlainText(((findChild(settingsPage, | ||
| "introPanelText")).text).replace(/’/g, "'")), | ||
| "Your Owner token will give you permissions to access the token management features for your community. This token is very important - only one will ever exist, and if this token gets lost then access to the permissions it enables for your community will be lost forever as well. | ||
| Minting your Owner token also automatically mints your community's TokenMaster token. You can airdrop your community's TokenMaster token to anybody you wish to grant both Admin permissions and permission to access your community's token management functions to. | ||
| Only the hodler of the Owner token can airdrop TokenMaster tokens. TokenMaster tokens are soulbound (meaning they can't be transferred), and you (the hodler of the Owner token) can remotely destruct a TokenMaster token at any time, to revoke TokenMaster permissions from any individual.") |
There was a problem hiding this comment.
Do we need to put the full text here? Maybe we could just check if it begins with the proper phrase? Having full string here doesn't help probably. We stil have not guarantee it's displayed properly at least. Btw. I would add check if the component is visible.
| tryCompare(mintTokensSettingsPanel.currentItem, "objectName", | ||
| "ownerTokenPage") | ||
|
|
||
| var settingsPage = findChild(mintTokensSettingsPanel.currentItem, |
There was a problem hiding this comment.
Suggested change
| var settingsPage = findChild(mintTokensSettingsPanel.currentItem, | |
| const settingsPage = findChild(mintTokensSettingsPanel.currentItem, |
|
it segfaults because the component crashes from time to time with qt 5.15.2 |
anastasiyaig
force-pushed
the
storybook-test-for-tokens-page
branch
from
5630652
to
b58d6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Simple test to check the text strings. Initial motivation is to remove such verifications from Squish tests and introduce them on lower level.
So this PR should replace verifications here:
status-desktop/test/e2e/gui/screens/community_settings_tokens.py
Line 105 in ea8827e
Why? Because I want to make Squish tests as functional as I can and QML tests are way faster