Ledger signer 211

[PhilippeR26]

Motivation and Resolution

Ledger has released a new version 2.1.1 of the Starknet APP.
It includes improvements, including a comprehensive display of the details of V1 & V3 transactions.

Starknet.js is now able to use APP v1.1.1 & v2.1.1.

Usage related changes

Important

No breaking changes for code using Ledger APP v1.1.1 (just no comprehensive display, only blind signatures)

• For users still using v1.1.1 :
  No change of the code :

const myLedgerSigner = new LedgerSigner(myLedgerTransport, 0);

LedgerSigner and LedgerSigner111 classes are equivalent.

• For new users, using v2.1.1 to create a new account :

const myLedgerSigner = new LedgerSigner211(myLedgerTransport, 0);

They can also use the v1.1.1 signer ; they will only not have access to the display of transaction details.

• For new users, using v1.1.1 to create a new account that will be natively compatible with v2.1.1 :

const myLedgerSigner = new LedgerSigner111(myLedgerTransport, 0, undefined, getLedgerPathBuffer211);

• For users that have created an account with V1.1.1, and are now using v2.1.1 :

const myLedgerSigner = new LedgerSigner211(myLedgerTransport, 0, getLedgerPathBuffer111);

Development related changes

LedgerSigner and getLedgerPathBuffer are still there, and are related to v1.1.1 APP.
They are now also named LedgerSigner111 and getLedgerPathBuffer111.

LedgerSigner211 and getLedgerPathBuffer211 have been created to handle v2.1.1.

As several functions are common for both signers, the LedgerSigner211 is an extension of the LedgerSigner111.

Some maths included in hashFeeField (utils/hash/transactionHash/v3.ts) are necessary, and have been isolated in exportable functions.

The new signer has been tested successfully in Node ( https://github.com/PhilippeR26/starknet.js-workshop-typescript/blob/main/src/scripts/ledgerNano/6.testLedgerAccount211.ts ) and in a demo DAPP ( https://github.com/PhilippeR26/Starknet-Ledger-Wallet )

Checklist:

• Performed a self-review of the code
• Rebased to the last commit of the target branch (or merged it into my branch)
• Documented the changes in code (API docs will be generated automatically)
• Updated the tests
• All tests are passing

[ivpavici]

what is APDU ? :)

[PhilippeR26]

It's a Ledger wording, about a batch of bytes exchanged with a Nano.