(WIP) Fix #1469: (createTable deser exposes table command) add tests, change deserialization logic #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
changed the title
|
Fix here works but not completely convinced we want to take this approach -- however, if we do want to solve the issue something like this is needed. |
tatu-at-datastax
changed the title
|
PR hard to merge due to concurrent refactorings -- leaving open in case it needs to be revived; if so, will probably need to re-create. |
tatu-at-datastax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds reproduction of #1469 to show the issues, and changes deserialization to defer validation failures after APIFeature check.
Which issue(s) this PR fixes:
Fixes #1469
Checklist