Fix 'Cannot mix BigInt and other types' on zaps #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ekzyis
changed the title
ekzyis
force-pushed
the
fix-zap-cannot-mix-bigint
branch
from
fcd82b8
to
93216ae
Compare
ekzyis
force-pushed
the
fix-zap-cannot-mix-bigint
branch
from
93216ae
to
45ef2ff
Compare
ekzyis
commented
Nov 19, 2024
| } | ||
| const sybilFeePercent = await paidActions[dbInvoice.actionType].getSybilFeePercent?.(args, context) |
There was a problem hiding this comment.
I am not sure why this wasn't included in the context before but passed to the context of perform as a separate variable. Was there a specific reason for it that I missed?
ekzyis
commented
Nov 19, 2024
| @@ -186,8 +187,7 @@ async function beginPessimisticAction (actionType, args, context) { | |||
| async function performP2PAction (actionType, args, incomingContext) { | |||
| // if the action has an invoiceable peer, we'll create a peer invoice | |||
| // wrap it, and return the wrapped invoice | |||
| const { cost, models, lnd, me } = incomingContext | |||
| const sybilFeePercent = await paidActions[actionType].getSybilFeePercent?.(args, incomingContext) | |||
| const { cost, sybilFeePercent, models, lnd, me } = incomingContext | |||
There was a problem hiding this comment.
The incoming context now already includes sybilFeePercent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1570,
sybilFeePercentwas removed from the context. This broke zaps with fee credits becausesybilFeePercentwas now undefined.Additional Context
sybilFeePercentis now always included in any action context.Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6. I tested zaps with fee credits and pessimistic zaps via anon.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no