Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[for discussion] Network listener #7872

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[for discussion] Network listener #7872

wants to merge 5 commits into from

Conversation

yschimke
Copy link
Collaborator

Starting with the NetworkObserver from Coil https://github.com/coil-kt/coil/blob/1bb21950e0e49afb4b9901c7dcc4a868e7d3055d/coil-base/src/main/java/coil/network/NetworkObserver.kt#L4

Things we should do

  • noNewExchanges we we lose internet connectivity, or a particular network
  • logging of the network conditions (internet, types)
  • fast fail if no network

Things we could do

  • Refresh connections - replace with new network
  • request a network if possible

@yschimke yschimke requested a review from swankjesse May 29, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse Awaiting requested review from swankjesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke