Add support for Apple Watch in CoreAardvark #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing:
If there's no shared disk space between watch and iOS, then I guess it's up to the consumer to vend logs from the watch to the parent app. |
|
Tracking getting logs from the watch with #42 |
dfed
requested changes
Jan 11, 2017
| s.license = 'Apache License, Version 2.0' | ||
| s.summary = 'Aardvark is a library that makes it dead simple to create actionable bug reports. Usable by extensions.' | ||
| s.homepage = 'https://github.com/square/Aardvark' | ||
| s.authors = 'Square' | ||
| s.source = { :git => 'https://github.com/square/Aardvark.git', :tag => "CoreAardvark/#{ s.version.to_s }" } | ||
| s.ios.deployment_target = '8.0' | ||
| s.watchos.deployment_target = '3.0' |
There was a problem hiding this comment.
Build is failing. Looks like watch doesn't know about UIApplicationWillTerminateNotification.
… do the same task
dfed
reviewed
Jan 11, 2017
| @@ -57,4 +57,7 @@ | |||
| /// Removes all logs. Completion handler is called on the main queue. | |||
| - (void)clearLogsWithCompletionHandler:(nullable dispatch_block_t)completionHandler; | |||
|
|
|||
| /// Waits for all of the pending logs to distribute from the log distributor, then saves with optional wait. This is done automatically when platform=ios, but must be done manually in watchos, preferably in WKExtensionDelegate applicationWillResignActive; | |||
There was a problem hiding this comment.
Let's be clear as to when this is called on iOS.
| @@ -128,12 +130,17 @@ - (void)clearLogsWithCompletionHandler:(nullable dispatch_block_t)completionHand | |||
| } | |||
| } | |||
|
|
|||
| - (void)waitForPendingLogsThenSaveAndWait:(BOOL)wait; | |||
There was a problem hiding this comment.
I'm not sure how much the wait parameter gives us here, since we're already waiting for one thing. Maybe just waitUntilAllLogsConsumedAndArchiveSaved?
dfed
approved these changes
Jan 11, 2017
|
Merge when green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be all that's needed, but we'll have to see. Never tried making code that is shared between platforms watchos and ios