Antora #2801
Merged
Antora #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
OK. I'm good to merging this.
Whatever is wrong or missed we can fixed in the subsequent changes.
Anyway I don't think it will be related to Antora or Rob responsibility.
Let me know, @garyrussell , if you ready to accept such a big change!
Merged
|
@artembilan Fine with me; thanks for reviewing. |
|
let me know if it is OK to turn this draft to normal PR and merge. Thanks |
|
@artembilan I was waiting on the secrets to get setup properly. Both PRs are now ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.