Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DestinationTopicPropertiesFactory CTORs #2793

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Deprecate DestinationTopicPropertiesFactory CTORs #2793

merged 1 commit into from
Sep 1, 2023

Conversation

garyrussell
Copy link
Contributor

So they can be removed in 3.1, along with FixedDelayStrategy.

@garyrussell garyrussell added this to the 3.0.12 milestone Aug 31, 2023
@garyrussell garyrussell changed the base branch from main to 3.0.x September 1, 2023 00:11
artembilan
artembilan requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe something is wrong with this PR and probably its branch has been made against main, but not 3.0.x.

Please, look if that can be fixed or just open a new one against expected upstream.

Thanks

@garyrussell
Deprecate DestinationTopicPropertiesFactory CTORs
1d91a7f 
So they can be removed in 3.1, along with `FixedDelayStrategy`.
@garyrussell
Copy link
Contributor Author

Oops - done.

@artembilan artembilan merged commit 1dde70a into spring-projects:3.0.x Sep 1, 2023
1 check passed
@garyrussell garyrussell deleted the deprec2 branch September 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
3.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan