BATCH-2275: added support to read/write from/to Couchbase #5
Conversation
|
|
||
| ##### NOTE | ||
| The limit attribute from the Query object will be used for paged requests. Setting the page and pageSize fields (inherited from AbstractPaginatedDataItemReader) will have no effect. | ||
| If the limit attribute is not set on the Query object, then the pageSize (inherited from AbstractPaginatedDataItemReader) will be set as the limit. |
There was a problem hiding this comment.
Instead of the conditional, is there a reason not to just override it so the reader can be consistent with the other reader behaviors?
There was a problem hiding this comment.
Hi,
Sorry I did not get you. Could you kindly elaborate a bit more.
There was a problem hiding this comment.
You're checking to see if the Query has the limit set. Is there a reason why you wouldn't just always override the limit with what's configured in the reader (or at least giving the values in the reader precedence)?
There was a problem hiding this comment.
Hello,
Apologies for the late reply. Changes have been made.
AbstractPaginatedDataItemReader will now be used to set the limit on the data returned by the query. updated README file
|
it's helpful! i wonder when will release this version? |
|
@hasnainjaved As mentioned in #46 , we are planning to start releasing modules from this repository to Maven Central so that the community can benefit from them without having to build/host the artefacts. As the author of this couchbase item reader/writer, would you be interested in taking the lead on this module? Looking forward to your feedback. |
fmbenhassine
added
status: waiting-for-feedback
and removed
status: waiting-for-triage
labels
|
Is couchbase read/write suppoert in spring batch released? I have requirement of reading data from couchbase db in batches and send event to kafka |
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.
confirmation code is: 8662014070602225