Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery IT test with null optional and empty repeated values #5040

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RustedBones
Copy link
Contributor

No description provided.

Comment on lines 78 to 79
it should "work with selectedFields" in {
val expected = (0 until 10).map(newNestedWithFields).asJava
Copy link
Contributor Author

@RustedBones RustedBones Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test now fails with

Expected: iterable with items [<NestedWithFields(Required$2(0,0),None)>, <NestedWithFields(Required$2(1,1),Some(Optional$2(1)))><NestedWithFields(Required$2(2,2),Some(Optional$2(2)))>, ...] in any order
     but: not matched: <NestedWithFields(Required$2(0,0),Some(Optional$2(0)))>

Tried to debug but it seems it comes from the bigquery session. avro bytes sent tell the optional.int field is set to 0. There is probably an issue with projection in the library.

@RustedBones RustedBones changed the title IT test with null and empty values BigQuery IT test with null and empty values Oct 20, 2023
@RustedBones RustedBones changed the title BigQuery IT test with null and empty values BigQuery IT test with null optional and empty repeated values Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.12%. Comparing base (6ebf9c4) to head (fdbbfc3).
Report is 28 commits behind head on main.

❗ Current head fdbbfc3 differs from pull request most recent head 12d2ba9. Consider uploading reports for the commit 12d2ba9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5040      +/-   ##
==========================================
+ Coverage   62.69%   63.12%   +0.42%     
==========================================
  Files         301      286      -15     
  Lines       10848    10743     -105     
  Branches      773      791      +18     
==========================================
- Hits         6801     6781      -20     
+ Misses       4047     3962      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant