Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Attempt to uncover and resolve test flakiness in 'test_linkcheck_exclude_documents'. #12189

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix (test suite)

Purpose

Detail

  • Initially this pull request should update the application code to make the occurrence of the problem more likely -- ideally 50% occurrence rate in our workflow jobs -- so that the problem becomes easier to confirm.
  • After we have found a reliable way to replicate and observe the problem, we can apply a fix. Continuous integration workflows should begin passing reliably again.
  • Finally, the temporary changes to the application code should be reverted.

Relates

… Ubuntu Launchpad's infrastructure status is confirmed reliable again.
@jayaddison
Copy link
Contributor Author

Initially this pull request should update the application code to make the occurrence of the problem more likely -- ideally 50% occurrence rate in our workflow jobs -- so that the problem becomes easier to confirm.

Unit test results:

Passes (expected to be ~50%):

Failures (expected to be ~50%):

@jayaddison
Copy link
Contributor Author

After we have found a reliable way to replicate and observe the problem, we can apply a fix. Continuous integration workflows should begin passing reliably again.

This appears true for the test results of 6a3d3d9 (essentially: confirming that a in results and then b in results, instead of confirming results == [a, b]).

jayaddison and others added 4 commits March 24, 2024 09:46
@jayaddison jayaddison marked this pull request as ready for review March 24, 2024 10:00
@jayaddison jayaddison requested a review from picnixz March 24, 2024 21:24
@picnixz picnixz merged commit 0ef96a7 into sphinx-doc:master Mar 25, 2024
22 checks passed
@picnixz
Copy link
Member

picnixz commented Mar 25, 2024

Thank you!

@jayaddison jayaddison deleted the issue-12188/test-linkcheck-exclude-documents-flakiness branch March 25, 2024 11:10
@jayaddison
Copy link
Contributor Author

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants