Ensure determinstic dict ordering to ensure builds are reproducible. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://reproducible-builds.org/ Signed-off-by: Chris Lamb <[email protected]>
|
Seems legit. Thanks! |
|
Friendly ping on this? :) |
|
Haven't gotten to clearing out my bugfix milestones yet - hope to soon! Sorry for the wait. |
|
Any luck yet @bitprophet ? :) |
|
Friendly ping on this @bitprophet ? grin |
|
Pings don't really help, sorry :D it gets done when it gets done! (Also, the last week has been...bad.) |
Sooo tempting to ping this PR ;-) |
|
I haven't given Alabaster love in a while 😭 Hoping to do that once I get over a hump with my other projects. Not promising an ETA because every time I do I jinx myself 😩 |
|
♥ |
|
Gentle ping on this? Open since 2016 now :) |
|
Dictionaries are now ordered, so I think this PR isn't needed (thank you, though!) A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://reproducible-builds.org/
Signed-off-by: Chris Lamb [email protected]