Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Don't put an underline on linked images" #125

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

jab
Copy link
Contributor

@jab jab commented Nov 16, 2017

The changes in bb5dbf9 and 585c081 to clear the bottom border are getting overridden by the styles applied immediately below. (Was this ever working?)

Here is a fresh screenshot from http://docs.python-requests.org/ (a prominent Alabaster consumer) showing the underline on the license badge while hovering over it:
screen shot 2017-11-16 at 12 40 27
(my cursor got hidden by the screenshot, but it was hovering right over the license badge)

Swapping the order of these rules results in the styles getting applied as intended.

Thanks in advance for taking a look and thanks for the great work on Alabaster!

The changes in bb5dbf and 585c08 to clear the bottom border
are immediately getting overridden by the styles right below.
Swap the order so these styles are applied as intended.
@jab
Copy link
Contributor Author

jab commented Nov 22, 2017

ping @bitprophet, this should be a quick review

@jab
Copy link
Contributor Author

jab commented Jul 3, 2018

@bitprophet Any reason not to merge this?

@bitprophet bitprophet added this to the 0.7.11 milestone Jul 5, 2018
@bitprophet bitprophet modified the milestones: 0.7.11, 0.7.12 Sep 6, 2018
Copy link
Contributor

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AA-Turner AA-Turner merged commit 17e55e5 into sphinx-doc:master Jul 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants