Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add redirect for seesparkbox.com #49

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

jonoliver
Copy link
Member

@jonoliver jonoliver commented May 21, 2024

Description

Adds a redirect rule to redirect apprentices.seesparkbox.com to apprentices.sparkbox.com. This rule would work in conjuction with the ALIAS record for apprentices.seesparkbox.com in DNSimple that points to the underlying Netlify site.

Validation

  1. The redirect structure can be validated by pasting the toml contents into https://redirects-playground.netlify.app/
  2. Because this requires testing the TLD and our deploy previews use the Netlify URL, I'm unsure of how to test this other than merging and deploying. However, I believe that this can be safely tested in production without adverse affects on apprentices.sparkbox.com.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for sb-apprentices ready!

Name Link
🔨 Latest commit 2e514d6
🔍 Latest deploy log https://app.netlify.com/sites/sb-apprentices/deploys/664d0ad16605a00008f95f8c
😎 Deploy Preview https://deploy-preview-49--sb-apprentices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

The snapshot test included footer, which uses the Date object for the copyright data.
This fix mocks the Date object in the test so that it doesn't change.
@jonoliver jonoliver force-pushed the chore--redirect-seesparkbox branch from b8e4c90 to 2e514d6 Compare May 21, 2024 20:57
@jonoliver jonoliver marked this pull request as ready for review May 24, 2024 15:52
@jonoliver jonoliver merged commit 2e514d6 into main May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants