Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial syntax fix to avoid SyntaxWarning #351

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Sep 16, 2024

Trivial (one character!) fix to avoid a SyntaxWarning in python 3.12+. Starting in 3.12, python has gotten stricter about backslash escape sequences in strings.

Without this fix:

In [1]: import pysiaf
pysiaf/pysiaf/aperture.py:1401: SyntaxWarning: invalid escape sequence '\*'
  """Sky to Tel frame transformation. Requires an attitude matrix.

With this fix: No warning is produced. .

@mperrin mperrin self-assigned this Sep 16, 2024
@Witchblade101
Copy link
Collaborator

@mfixstsci Let's merge this and add back the 3.12 support temporarily removed from the CI the other day.

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @Witchblade101

@mfixstsci mfixstsci merged commit c835ef2 into spacetelescope:main Sep 17, 2024
4 checks passed
@mperrin mperrin deleted the escape_sequence_fix branch September 18, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants