Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman dev - WIP #296

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Conversation

Witchblade101
Copy link
Collaborator

My quick-and-dirty attempt at adding the Roman SIAF to PySIAF from February. This definitely still needs some cleaning up, the tests added, and documentation, but I wanted to make sure Mees and Tyler have a chance to look at it.

@mfixstsci
Copy link
Collaborator

Hey @Witchblade101 thank you for submitting this! I can review it and let you know what I think!

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I say we revisit this once the code for Roman matures a little bit, but being able to generate the apertures is a great first step. Thanks @Witchblade101!

@mfixstsci
Copy link
Collaborator

@Witchblade101 is this PR still a WIP? Besides displaying the apertures, have there been any more coding updates or changes @tddesjardins?

@tddesjardins
Copy link

@mfixstsci no further updates here. All the existing tools for transformations in pysiaf work for us, and we don't currently plan to include the SIAF generation code in this repo (at least, not yet?).

@bmorris3
Copy link

Hi folks! In jdaviz we now support instrument footprint overlays on images in Imviz (spacetelescope/jdaviz#2341) via pysiaf. For example, here's the NIRCam FOV overlaid on a Roman exposure:

NIRCam on Roman exposure

Is there a timeline for merge for the Roman features in this PR? Thanks!

@tddesjardins
Copy link

Re-pinging @mfixstsci and @Witchblade101 to see if we can close the loop on this soon.

@Witchblade101 Witchblade101 merged commit 62d5fb8 into spacetelescope:master Sep 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants