Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for upcoming changes in photutils #8058

Closed

Conversation

mcara
Copy link
Member

@mcara mcara commented Nov 7, 2023

Takes care of a part of https://jira.stsci.edu/browse/JP-3457

Closes #8014

This PR addresses an incoming API change in photutils, see astropy/photutils#1640

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara added this to the Build 10.0.1 milestone Nov 7, 2023
@mcara mcara self-assigned this Nov 7, 2023
@mcara mcara requested a review from a team as a code owner November 7, 2023 03:33
@mcara mcara requested review from nden and hbushouse November 7, 2023 03:33
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
jwst/tweakreg/tweakreg_step.py 63.54% <100.00%> (+1.86%) ⬆️
jwst/source_catalog/source_catalog.py 97.72% <75.00%> (-0.22%) ⬇️

📢 Thoughts on this report? Let us know!

@nden nden requested review from larrybradley and removed request for nden November 7, 2023 08:38
@nden
Copy link
Collaborator

nden commented Nov 7, 2023

This does not solve the issue and I see that #8014 is an alternative solution.
@larrybradley Just want to make sure this backwards incompatible change is on purpose and we need to make the change in the pipeline. If so it looks like #8014 is the way to go.

@mcara
Copy link
Member Author

mcara commented Nov 7, 2023

I see... I got first failures fixed but now tests are failing because they test for presence of the old version in meta.

If this need to be preserved than indeed a fix like the one in #8014 would be the correct approach.

@mcara
Copy link
Member Author

mcara commented Nov 7, 2023

Closing in favor of #8014

@mcara mcara closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants