[ENG-1963] Filesystem actions upgrade #2833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamiepine
commented
Dec 15, 2024
•
jamiepine
commented
- Implement all remaining filesystem actions into the new job system
- Add undo support
- Remove ephemeral API entirely
- Refactor core into crates
…908-migrate-file-deletion-to-the-new-file-management-sub-crate
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Implements hash verification in the StreamCopyBehavior to validate successful file copies. This ensures data integrity by comparing source and target file hashes after copying. - Added blake3 hash verification during streaming copy operations - Created DeleteBehavior trait for flexible file deletion strategies - Made StreamCopyBehavior generic over DeleteBehavior for extensibility - Implemented LocalDeleteBehavior for filesystem operations - Added delete_on_success option to remove source after verification Hash verification is enabled by default for stream copies but can be disabled. The deletion behavior system is designed to support future cloud storage operations.
- Introduce reversible job system with undo capabilities - Remove location_id coupling from job system core - Consolidate file operations by merging mover into copier - Update job system documentation and architecture docs
This commit restructures the core module by splitting it into smaller, more focused crates to improve modularity and maintainability. Key changes include: - Split job-related functionality into dedicated crates: - job-system: Core job execution infrastructure - job-errors: Centralized error handling - file-actions: File operations (copy, delete) - location-scan: File identification and indexing - Extracted core components into separate crates: - context - custom-uri - device (formerly node) - library - location - preferences - search - tag - volume - Renamed crates for clarity: - file-path-helper -> file-helper - sync -> library-sync - heavy-lifting -> location-scan This restructuring improves code organization, reduces coupling, and makes the codebase more maintainable.
jamiepine
force-pushed
the
eng-1963-filesystem-actions-upgrade
branch
from
be89130 to
53aa0db
Compare
…pl_job_serialization_handler macro
- Move device crate functionality into new node crate - Move API into independent crate - Remove old job system files that were migrated to new system - Migrate device crate to node - Update dependencies and references to use new node crate - Fix more import errors - Still huge WIP, loads more errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.