[ENG-1782, ENG-1781, ENG-1780] Add support for flatpak builds

[greendoescode]

Adds flatpak support, with flatpak github workflow.
Still in draft, due to gstreamer plugins not properly being built.

Addresses #1542, but does not fully close.

[vercel]

@greendoescode is attempting to deploy a commit to the Spacedrive Team on Vercel.

A member of the Team first needs to authorize it.

[greendoescode]

Current known issues:
Video and audio playback using Quick View does not work, causes app to hang and then crash.

[greendoescode]

Sorry for the bland commit history, I do normally use conventional commits lol

[greendoescode]

I've been holding out creating the draft PR until I had a working github workflow, which I do indeed have now.

[greendoescode]

Just found another issue, with spacedrop.

  2024-08-14T19:56:16.227183Z ERROR sd_core: panicked at /home/runner/work/spacedrive/spacedrive/core/src/p2p/operations/ping.rs:36:10:
Failed to send pong: Custom { kind: ConnectionReset, error: Stopped(0) }, panic.file: "/home/runner/work/spacedrive/spacedrive/core/src/p2p/operations/ping.rs:36", panic.column: 10
    at core/src/lib.rs:292

fatal runtime error: failed to initiate panic, error 3

Not quite sure why, if someone could lmk so I could diagnose, I'd appreciate it.
I'll have a look and try and figure it out though, it might be permissions 🤷

[greendoescode]

Just found another issue, with spacedrop.

  2024-08-14T19:56:16.227183Z ERROR sd_core: panicked at /home/runner/work/spacedrive/spacedrive/core/src/p2p/operations/ping.rs:36:10:
Failed to send pong: Custom { kind: ConnectionReset, error: Stopped(0) }, panic.file: "/home/runner/work/spacedrive/spacedrive/core/src/p2p/operations/ping.rs:36", panic.column: 10
    at core/src/lib.rs:292

fatal runtime error: failed to initiate panic, error 3

Not quite sure why, if someone could lmk so I could diagnose, I'd appreciate it. I'll have a look and try and figure it out though, it might be permissions 🤷

OKAY so, it seems to be a general issue with spacedrive on linux, or fedora.
I ran pnpm tauri dev instead of my flatpak builds on both devices and the same error occurs

[greendoescode]

I was also wondering about getting a pr setup on Flathub?
Their CI is alot better and it'd be good for them to look over my config, might even be able to have input on soem of the problems.

[HeavenVolkoff]

Hey @greendoescode sorry for the delay in reviewing this. I was busy with some other tasks, but I will take a look at this PR until the end of this week.

About submitting this to flatpak, I think they prefer that you compile the app with flatpak-builder for it to be approved upstream. If I am not mistaken they only accept .deb repackaging if the app is proprietary. Also, personnaly, I would prefer to only publish the app officialy on flatpak after we released the beta (which requires some stability and performance improvements and a couple of features before we release it)

[greendoescode]

Hey @greendoescode sorry for the delay in reviewing this. I was busy with some other tasks, but I will take a look at this PR until the end of this week.

About submitting this to flatpak, I think they prefer that you compile the app with flatpak-builder for it to be approved upstream. If I am not mistaken they only accept .deb repackaging if the app is proprietary. Also, personnaly, I would prefer to only publish the app officialy on flatpak after we released the beta (which requires some stability and performance improvements and a couple of feature before we release it

For sure, makes complete sense.
Kind of forgot that doing stuff locally is probably better haha

Also, they do accept it if it's open source, another user in the discord server proved this when they submitted their PR to flathub and it got accepted.

[ameer2468]

Hey @greendoescode thank you very for much for the valuable contribution, i just realized this has been accidently marked as ready for review, is it ready though?

[greendoescode]

Hey @greendoescode thank you very for much for the valuable contribution, i just realized this has been accidently marked as ready for review, is it ready though?

It is not, still a draft :)

[Tahinli]

Hey @greendoescode thank you very for much for the valuable contribution, i just realized this has been accidently marked as ready for review, is it ready though?

It is not, still a draft :)

When we are going to see flatpak sir ?
I'm not able to install with deb package so can't use spacedrive.

[greendoescode]

Hey @greendoescode thank you very for much for the valuable contribution, i just realized this has been accidently marked as ready for review, is it ready though?

It is not, still a draft :)

When we are going to see flatpak sir ?
I'm not able to install with deb package so can't use spacedrive.

I was waiting for 0.5.0 to be near completion to restart, lots of features that will test flatpaks sandbox abilities are available in the new release so I'll have to look

[Juan-de-Costa-Rica]

I am also waiting to test out a flatpak!

[iLynxcat]

heads up @greendoescode, we did a mega-merge of WIP 0.5.0 features into main so you may run into some merge conflicts next time you update from main. it likely will just reconcile perfectly within git, haven't tested. lemme know on Discord or here if you need any help merging!

(edit: I would be tempted to just do it and push to your fork but I'm not a fan of touching others' WIP code)