This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Core model logic for the Odyssey plugin #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamdandelion
force-pushed
the
plugin-core
branch
from
32f6383
to
363c9f9
Compare
teamdandelion
changed the title
This creates the core data structure for the Odyssey plugin, called an 'OdysseyInstance'. It supports adding entities (basically nodes) of type Person, Priority, or Contribution. You can take a look at our [design doc][dd] or [brainstorming] to get a sense of what's going on here, although the design has continued to evolve via in-person conversations. [dd]: #1 [brainstorming]: https://discourse.sourcecred.io/t/odyssey-manual-mode-brainstorming/62 See the `model.test.js` file for a sense of how the API looks when used in practice. Test plan: Unit tests included. `yarn test` passes.
teamdandelion
force-pushed
the
plugin-core
branch
from
363c9f9
to
24b477a
Compare
|
Got a LGTM from @BrianLitwin offline, gonna merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates the core data structure for the Odyssey plugin, called an
'OdysseyInstance'. It supports adding entities (basically nodes) of type
Person, Priority, or Contribution. You can take a look at our design
doc or brainstorming to get a sense of what's going on here,
although the design has continued to evolve via in-person conversations.
See the
model.test.jsfile for a sense of how the API looks when usedin practice.
Test plan: Unit tests included.
yarn testpasses.