Enable autowire and autoconfigure for sonata.user.admin.user service #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should we enable autowire and autoconfiguration for this service if it already injects all dependencies and tags? I think this change is not needed. |
|
@jordisala1991 what if i need to inject some additional services? For example file uploader service to upload user profile photo? |
Then it's your service which will need autoconfigure, not the one defined by sonata no ? Anyway, since none of our service use those tags, I think we should keep consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Enable autowire and autoconfigure for sonata.user.admin.user service
I am targeting this branch, because changes are related to current version.
Changelog