Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AdminLTE 3 #8103

Closed
wants to merge 1 commit into from

Conversation

core23
Copy link
Member

@core23 core23 commented Sep 18, 2023

Subject

This is a new approach to solve #7156. It is basically based on #7740.

I am targeting this branch, because the style update is a breaking change. Some css classes changed when upgrading from bootstrap 3 > 4 (e.g. box became card).

Closes #7156

Changelog

### Changed
- Add support for AdminLTE v3
- Add support for jQuery v3

To do

  • Do the upgrade
    • Update dependencies
    • Update all template
    • Update all PHP components
    • Update custom JavaScript
    • Update custom CSS
  • Test it on a real project
  • Update documentation
    • Update the documentation and screenshots
    • Update CHANGELOG
  • 3rd Party
    • Update SonataUserBundle login template
    • Update SonataMediaBundle admin template overrides

Functions to check

  • General layout (sidebar, top navigation, ...)
  • Filter list
  • Quick edit in list
  • Modal item selection
  • Show item page
  • Edit item page

Nice to have

  • Move inline JavaScript to admin.js
  • Remove deprecated bootlint

@core23 core23 added this to the 5.0 milestone Sep 18, 2023
@core23 core23 force-pushed the feature/upgrade-admin-lte branch 5 times, most recently from bd3a88b to 56780fb Compare September 18, 2023 18:55
@Seb33300
Copy link

I think your description is wrong, should be from bootstrap 3 > 4?

from bootstrap 3 > 5

AdminLTE 3 is using Bootstrap 4
AdminLTE 4 (WIP, not released yet) is using Bootstrap 5

@core23
Copy link
Member Author

core23 commented Sep 20, 2023

You're right. There's plenty to do to use bootstrap 5: https://github.com/ColorlibHQ/AdminLTE/milestone/7

@core23
Copy link
Member Author

core23 commented Oct 8, 2023

Paused until #8117 is solved

Copy link

github-actions bot commented Apr 5, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 5, 2024
@github-actions github-actions bot closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants