Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors prensence package to SM implementation #437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

snnsnn
Copy link

@snnsnn snnsnn commented May 15, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

⚠️ No Changeset found

Latest commit: ca9b4b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@snnsnn snnsnn changed the title Refactors prensence package to FSM implementation Refactors prensence package to SM implementation Jun 21, 2023
```typescript
const App = () => {
const [show, setShow] = createSignal(true);
const state = createPresence(show, { duration: 300, initialRun: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need it in any case, wouldn't it be better to provide state.mounted(), which you can use as <Show when={state.mounted()}>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants