Introducing channels #3308
Introducing channels #3308
Conversation
|
| ```ts | ||
| const rpcSubscriptions = | ||
| // Step 1 - Create an `RpcSubscriptions` instance. This may be stateful. | ||
| createSolanaRpcSubscriptions(mainnet('wss://api.mainnet-beta.solana.com')); | ||
| const response = await rpcSubscriptions | ||
| // Step 2 - Call supported methods on it to produce `PendingRpcSubscriptionsRequest` objects. | ||
| .slotNotifications({ commitment: 'confirmed' }) | ||
| // Step 3 - Call the `subscribe()` method on those pending requests to trigger them. | ||
| .subscribe({ abortSignal: AbortSignal.timeout(10_000) }); | ||
| // Step 4 - Iterate over the result. | ||
| try { | ||
| for await (const slotNotification of slotNotifications) { | ||
| console.log('Got a slot notification', slotNotification); | ||
| } | ||
| } catch (e) { | ||
| console.error('The subscription closed unexpectedly', e); | ||
| } finally { | ||
| console.log('We have stopped listening for notifications'); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I think this example is more suited for rpc-subscriptions than rpc-subscriptions-spec since it's the highest-level API we offer.
Perhaps it would be better to offer examples on how to use the new type here instead?
There was a problem hiding this comment.
I literally just copy-pasted this from @solana/rpc-spec.
I honestly don't understand the differences anymore.
Help me, Obi Wan…
steveluscher
force-pushed
the
10-02-unhook_all_of_the_subscription_augmenters_so_that_we_can_refactor_and_build_them_back_up_one_by_one
branch
from
ad092cf
to
e4260af
Compare
steveluscher
force-pushed
the
10-02-Introducing_channels
branch
from
7e8d6ca
to
f44dc4a
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Merge activity
|
steveluscher
changed the base branch from
10-02-unhook_all_of_the_subscription_augmenters_so_that_we_can_refactor_and_build_them_back_up_one_by_one
to
graphite-base/3308
steveluscher
force-pushed
the
10-02-Introducing_channels
branch
from
f44dc4a
to
997f4ca
Compare
Summary
Subscriptions are different from one-shot requests in that they need two things: a ‘transport’ to fulfil requests to subscribe to some kind of notifications, but also a ‘channel’ over which to send that subscription and wait for notifications. Channels might be shared by many subscriptions, so they need to be treated as a separate type.
In this PR we create the concept of the
RpcSubscriptionsChanneland theRpcSubscriptionsChannelCreator.