Pretty print failures better #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we pretty printed multiple failures as: ``` failures: A B C D ``` which gets very hard to read when tests have long names. This commit changes this to: ``` failures: A B C D ```
When multiple tests are (hopefully expectedly!) failing, sometimes you want to see if one particular test out of many is failing or succeeding. That was difficult before because failing tests were shown in an arbitrary order. This commit sorts them, case insensitive, in ascending order.
|
Agreed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cosmetic, but makes it much easier to see which tests are failing. Each commit hopefully motivates it appropriately.
To give an example, before:
``
failures:
lang_tests::float.newcg.c lang_tests::float_consts.newcg.c lang_tests::fp_to_si.newcg.c lang_tests::float_add.newcg.c lang_tests::double.newcg.c lang_tests::float_mul.newcg.c lang_tests::float_div.newcg.c lang_tests::udiv.newcg.c lang_tests::sdiv.newcg.c lang_tests::fcmp_double.newcg.c lang_tests::fcmp_float.newcg.c
failures:
lang_tests::double.newcg.c
lang_tests::fcmp_double.newcg.c
lang_tests::fcmp_float.newcg.c
lang_tests::float.newcg.c
lang_tests::float_add.newcg.c
lang_tests::float_consts.newcg.c
lang_tests::float_div.newcg.c
lang_tests::float_mul.newcg.c
lang_tests::fp_to_si.newcg.c
lang_tests::sdiv.newcg.c
lang_tests::udiv.newcg.c