Add test_path_filter and deprecate test_file_filter.
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. Thank you! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@jacob-hughes I always forget that "examples" aren't run by |
|
LGTM please squash |
`test_file_filter` filters out non-file things, which makes it impossible to, for example, use directories as tests. Rather than change the semantics of `test_file_filter`, this commit adds `test_path_filter` which doesn't filter out non-file things, but is otherwise identical to `test_file_filter`. It also marks `test_file_filter` as deprecated, with a generic way to migrate code to `test_path_filter`, allowing users to mechanically migrate their code.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_file_filterfilters out non-file things, which makes it impossible to, for example, use directories as tests.Rather than change the semantics of
test_file_filter, this commit addstest_path_filterwhich doesn't filter out non-file things, but is otherwise identical totest_file_filter. It also markstest_file_filteras deprecated, with a generic way to migrate code totest_path_filter, allowing users to mechanically migrate their code.