Use separate thread for finalisation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Apr 15, 2024
fnlz_mlc.c
Outdated
| @@ -22,8 +22,10 @@ | |||
| #if defined(KEEP_BACK_PTRS) || defined(MAKE_BACK_GRAPH) | |||
| /* The first bit is already used for a debug purpose. */ | |||
| # define FINALIZER_CLOSURE_FLAG 0x2 | |||
| # define IS_FINALIZED_FLAG 0x3 | |||
There was a problem hiding this comment.
Let's document what this flag means. I think it means HAS_BEEN_FINALIZED?
|
Please squash. |
This commit creates a finalisation thread in the GC_INIT() routine. The thread spins indefinitely waiting to process objects in the finaliser buffers. This commit also makes sure that once an object has been finalised, its finalised bit is set so that it is not re-added to the buffer the next time it becomes unreachable.
jacob-hughes
force-pushed
the
off_thread_finalization
branch
from
a3c3ff4
to
92f2fc0
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a finalisation thread in the GC_INIT() routine. The thread spins indefinitely waiting to process objects in the finaliser buffers.
This commit also makes sure that once an object has been finalised, its finalised bit is set so that it is not re-added to the buffer the next time it becomes unreachable.