Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "No mapboxgl detected in options" error #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akul-ka
Copy link

@akul-ka akul-ka commented Jul 17, 2019

Fix error No mapboxgl detected in options. Map markers are disabled. Please set options.mapboxgl. by providing mapboxgl prop.
Based on issue mapbox/mapbox-gl-geocoder#252

@vinayakkulkarni
Copy link

This one also needs to be patched soon!

@MrSunshyne
Copy link

I can't seem to get rid of that error even after using the patch.
Any clue @vinayakkulkarni @akul-ka ?

@RonAlmog
Copy link

any progress with this? I'm still getting this error, 'No mapboxgl detected in options. Map markers are disabled. Please set options.mapboxgl.' when placing the MglGeocoderControl inside a MglMap.

vinayakkulkarni added a commit to geospoc/v-mapbox-geocoder that referenced this pull request May 20, 2020
dd pushed a commit to dd/vue-mapbox-geocoder that referenced this pull request May 20, 2020
@jimblue
Copy link

jimblue commented Jun 4, 2020

Having the same issue, any update ?

@jimblue
Copy link

jimblue commented Jun 4, 2020

What still need to be done before merging this PR ?

@vinayakkulkarni
Copy link

@jimblue: I suggest you use https://github.com/geospoc/v-mapbox-geocoder as it's a maintained fork which has fixed all these tiny bugs, soal seems to be AFK for a while now

@jimblue
Copy link

jimblue commented Jun 5, 2020

@vinayakkulkarni thanks for the suggestion 😃
But it's sad that this main repo isn't well maintain 😞

woshikie added a commit to woshikie/vue-mapbox-geocoder that referenced this pull request Oct 22, 2020
* chore: add position prop

* fix: No mapboxgl detected in options. Map markers are disabled. Please set options.mapboxgl.

* update package

* fix: mapboxGl as prop not mapboxgl

* chore: update build

* chore: update package.json

* chore: update mapboxgl prop

* chore: update multi-query string

* chore: update build to support multiquery

* fix: typo error

* chore: update build

* feat: add marker as props

* fix: update build

* fix: update debouce issue caused by vue component

* fix: update build

* chore: remove the `_updateInput` method causing debounce issue

* chore: update build

* fix query method

* update passed props to MapboxGeocoder

* fix: remove dist build

* feat(bot): setup dependabot 🤖

* feat(bot): setup semantic pr 🤖

* chore: minor housekeeping 🧹

* feat(lint): add commitlint & husky 🏗

* chore(housekeeping): gitignore, prettier & babel configs 🥳

* refactor: remove public directory 📂

* feat(ci): add github action 🏗

* build(rollup): add rollup configs 👨‍🔧

* chore: add LICENSE 📓

* refactor(source): refactor GeoCoderCtrl & remove vue config file 💅

* docs: update README 🥳

* feat: add jsconfig for better intellisense 🔌

* refactor: add package.json & lockfile 🚀

* chore: update lockfile to include ship.js

* chore: release v0.1.0 (soal#5)

* chore(deps): update lockfile with correct scope

* chore: release v0.1.1 (soal#7)

* chore(deps-dev): bump rollup from 2.10.4 to 2.10.5

Bumps [rollup](https://github.com/rollup/rollup) from 2.10.4 to 2.10.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.10.4...v2.10.5)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* fix: stop squishing results after updating input

- ref: soal#14

* fix: typo issue

* chore: update docs

- ref soal#10

* fix: no mapboxgl detected issue

- ref soal#8

* feat: add geocoder based on custom container_id

* docs: update example

* feat: add badges

* chore: update alignment

* chore: release v0.2.0 (soal#15)

* Add `prepare` script

It is needed for the `npm i git+https://github.com/dd/vue-mapbox-geocoder.git` command to build the package

Co-authored-by: Vinayak Kulkarni <[email protected]>
Co-authored-by: Vinayak Kulkarni <[email protected]>
Co-authored-by: dd <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Alexander Kaidalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants